Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44187 )
Change subject: soc/intel/common/cse_lite: Perform a board specific reset ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44187/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44187/1//COMMIT_MSG@9 PS1, Line 9: ME this is functionality that is specific to CSE Lite
https://review.coreboot.org/c/coreboot/+/44187/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/44187/1/src/soc/intel/common/block/... PS1, Line 360: /* Default weak implementation, does nothing. */ Should this weak function contain the `do_global_reset()`, since that would become the default implementation for boards that don't need the workaround?