Hello Chris Wang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/29179
to review the following change.
Change subject: mb/google/kahlee/variants/liara: enable 2T mode for liara. ......................................................................
mb/google/kahlee/variants/liara: enable 2T mode for liara.
To enable 2T mode will help the liara auto restart issue. So reverting the CL:28726(Disable NbP-state on Liara) and using 2T mode instead
BUG=b:116082728 TEST=verify the 2T mode is enabled/boot info ChromOS and no auto restart/run memtester passed 10 cycle.
Change-Id: I3a96276d88ffb70530d72b15c07b59a01cc6209a Signed-off-by: chris wang chris.wang@amd.corp-partner.google.com --- M src/mainboard/google/kahlee/OemCustomize.c M src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c 2 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/29179/1
diff --git a/src/mainboard/google/kahlee/OemCustomize.c b/src/mainboard/google/kahlee/OemCustomize.c index d78f784..f6454df 100644 --- a/src/mainboard/google/kahlee/OemCustomize.c +++ b/src/mainboard/google/kahlee/OemCustomize.c @@ -32,6 +32,11 @@ ODT_TRI_MAP(ANY_SOCKET, ANY_CHANNEL, 0xff, 0xff, 0xff, 0xff), CS_TRI_MAP(ANY_SOCKET, ANY_CHANNEL, 0xff, 0xff, 0xff, 0xff, 0x00, 0x00, 0x00, 0x00), +#if IS_ENABLED(CONFIG_BOARD_GOOGLE_LIARA) + TBLDRV_CONFIG_TO_OVERRIDE(DIMMS_PER_CHANNEL, ANY_SPEED, VOLT_ANY_, + ANY_), + TBLDRV_CONFIG_ENTRY_SLOWACCMODE(1), +#endif PSO_END };
diff --git a/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c b/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c index e9cf5c8..42d9a49 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c +++ b/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c @@ -152,7 +152,4 @@ InitEarly->GnbConfig.PsppPolicy = PsppBalanceLow; InitEarly->PlatformConfig.GnbAzI2sBusSelect = GnbAcpI2sBus; InitEarly->PlatformConfig.GnbAzI2sBusPinConfig = GnbAcp2Tx4RxBluetooth; - if ((IS_ENABLED(CONFIG_BOARD_GOOGLE_LIARA)) && (board_id() <= 4)) - InitEarly->PlatformConfig.PlatformProfile.NbPstatesSupported = - FALSE; }