Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34477 )
Change subject: Makefile: Support HAVE_BOOTBLOCK=n case
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34477/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34477/1//COMMIT_MSG@13
PS1, Line 13: at the end.
I thought we made this bit optional now? Sorry, I didn't dig into the details on that.
Reading src/lib/cbfs.c: cbfs_master_header_props() suggests it is not optional. Maybe not needed with VBOOT?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34477
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaee9200f72f31175aca597865e3c74fc68bec8a6
Gerrit-Change-Number: 34477
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 23 Jul 2019 18:43:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment