Attention is currently required from: Paul Menzel, Julius Werner. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59497 )
Change subject: libpayload: Implement new CBFS access API ......................................................................
Patch Set 15:
(4 comments)
File payloads/libpayload/Kconfig:
https://review.coreboot.org/c/coreboot/+/59497/comment/4075b6cb_dba39aff PS8, Line 211: config CBFS
I mean they're still in the same menu in menuconfig (since you're including libcbfs/Kconfig right he […]
Done
File payloads/libpayload/include/cbfs_glue.h:
https://review.coreboot.org/c/coreboot/+/59497/comment/86b91ff9_ae406fd8 PS3, Line 38: {
Not quite sure what you mean by "before".
If I recall correctly, there was an issue with this in cbfs_walk() some time ago. I was trying to fix it, but you were faster in CB:57271
Regarding the bounds checks: After thinking about this, I came to the conclusion, that checks you proposed should be enough. Cases covered in this function should not be bound to the device, so offset + size overflow and too large request should be handled here. Other cases will belong to the boot_device_read() function.
File payloads/libpayload/libcbfs/Kconfig:
https://review.coreboot.org/c/coreboot/+/59497/comment/3032795b_6421b0c4 PS8, Line 16: RO (COREBOOT) region if it isn't available in the active RW region.
This should mention that this only makes sense if CONFIG_VBOOT is enabled in coreboot. […]
Done
File payloads/libpayload/libcbfs/cbfs.c:
https://review.coreboot.org/c/coreboot/+/59497/comment/259417b6_de41cf7c PS8, Line 111: ERROR("Buffer allocation failed");
nit: would be nice to add mdata->h. […]
Done