Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36851 )
Change subject: vendorcode/eltan/security: Move eltan security from chipset to security menu
......................................................................
Patch Set 3:
Patch Set 1:
I believe it was placed where it was placed because ordering unfortunately matters in the evaluation of Kconfig options.
I had a new look at it. To avoid any risk the vendorcode menu is left where it was in the chipset area. The vendorcode/eltan/Kconfig is removed is it doesn't show up in the chipset menu any longer. I added the vendorcode/eltan/security/Kconfig to the security menu so it conditionally shows up.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36851
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b2aa3836e8d9a3242c6d1f3ba7b7821a5cfb9d3
Gerrit-Change-Number: 36851
Gerrit-PatchSet: 3
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Fri, 15 Nov 2019 09:17:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment