Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47993 )
Change subject: drivers/intel/fsp2_0: introduce possibility of using a full FD binary
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47993/4/src/drivers/intel/fsp2_0/Kc...
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/47993/4/src/drivers/intel/fsp2_0/Kc...
PS4, Line 60: !FSP_USE_REPO
Why did this change to !FSP_USE_REPO?
https://review.coreboot.org/c/coreboot/+/47993/4/src/drivers/intel/fsp2_0/Kc...
PS4, Line 88: Use a combined FSP FD file instead of individual, split binaries.
Probably say that this takes as input a combined FSP FD file instead of individual, split binaries and converts them to individual, split binaries at build time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47993
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cb98c1ff319823a2a8a95444c9b4f3d96162a02
Gerrit-Change-Number: 47993
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 25 Nov 2020 14:38:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment