Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47431 )
Change subject: soc/intel/common: Generate the CSE RW metadata and add to FW_MAIN_A/B ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47431/7/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/47431/7/src/soc/intel/common/block/... PS7, Line 26: openssl dgst -sha256 -hex $(CSE_RW_PATH) | cut -d " " -f2 | fold -w2 | paste -sd',' -) May I suggest the following? ``` openssl dgst -sha256 -hex $(CSE_RW_PATH) | cut -d" " -f2 | awk '{gsub(/.{2}/,"0x&, ")}1' ```
It will have the following format: ``` twawrzynczak@twawrzynczak ~/trunk/src/third_party/coreboot $ openssl dgst -sha256 -hex me_rw-volteer2.bin | cut -d" " -f2 | awk '{gsub(/.{2}/,"0x&, ")}1' 0x1b, 0x41, 0x6b, 0xbc, 0xbc, 0x5c, 0x86, 0xb8, 0xb6, 0x90, 0x10, 0x28, 0x5d, 0x33, 0xb4, 0xc9, 0xb1, 0xe4, 0x92, 0x96, 0x7f, 0x4d, 0xe0, 0x54, 0xa1, 0xd8, 0xcc, 0x07, 0x08, 0xd1, 0x56, 0xf2, ```
which should make the "HASH_TO_ARRAY" macro unnecessary
https://review.coreboot.org/c/coreboot/+/47431/7/src/soc/intel/common/block/... PS7, Line 27: $(HASH) "${HASH}"