[coreboot-gerrit] Change in coreboot[master]: sb/intel/common: Add AHCI library

[Angel Pons (Code Review)]

Attention is currently required from: Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47023 )

Change subject: sb/intel/common: Add AHCI library
......................................................................

Patch Set 5:

(2 comments)

File src/southbridge/intel/common/ahci.h:

https://review.coreboot.org/c/coreboot/+/47023/comment/d8168ab2_96a0a496 
PS5, Line 3: #ifndef __SOUTHBRIDGE_INTEL_COMMON_AHCI_H__
> besides 0x1c is there anything intel specific here? […]

Which 0x1c?

I don't know if there's any Intel-specific stuff in here.

https://review.coreboot.org/c/coreboot/+/47023/comment/4269f279_f8b19f94 
PS5, Line 46: 	struct {
> once in src/include/ this and the other structs must also support big endian.

Agreed. If this ends up in src/include, the bitfields will have to go.