[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Add support for CSE Lite driver to handle CSE RW an...

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46312 )

Change subject: soc/intel/common: Add support for CSE Lite driver to handle CSE RW and metadata
......................................................................

Patch Set 10:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46312/10/src/soc/intel/common/block... 
File src/soc/intel/common/block/cse/cse_lite.c:

https://review.coreboot.org/c/coreboot/+/46312/10/src/soc/intel/common/block... 
PS10, Line 568: 	printk(BIOS_SPEW, "cse_lite: CSE CBFS RW version : %d.%d.%d.%d\n",
              : 			source_info->fw_ver.major,
              : 			source_info->fw_ver.minor,
              : 			source_info->fw_ver.hotfix,
              : 			source_info->fw_ver.build);
Logged again in line 594. So not required.

https://review.coreboot.org/c/coreboot/+/46312/10/src/soc/intel/common/block... 
PS10, Line 576: 	for (uint8_t i = 0; i < VB2_SHA256_DIGEST_SIZE; i++)
              : 		printk(BIOS_SPEW, "%x", source_info->hash[i]);
              : 
              : 	printk(BIOS_SPEW, "\n");
Do we need to log SHA Digest? Not sure how it helps with debugging.