Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36207 )
Change subject: ec/google/chromeec: Add EC driver support for software sync ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36207/7/src/ec/google/chromeec/ec.h File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/36207/7/src/ec/google/chromeec/ec.h... PS7, Line 153: google_chromeec_hello Function header/documentation?
https://review.coreboot.org/c/coreboot/+/36207/7/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/36207/7/src/ec/google/chromeec/ec.c... PS7, Line 694: sizeof(struct ec_host_request); Looks like an inconsistent indentation.