Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18669 )
Change subject: soc/intel/common/block: Add Intel common PCR support
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/18669/3/src/soc/intel/apollolake/include/soc...
File src/soc/intel/apollolake/include/soc/pcr_ids.h:
Line 1: /*
We have lots of things being added. But nothing being removed? If you are g
initially i have created 6 patch for entire PCR, later i thought lets have only common code + 2 SOC using that common code along with clean up.
If you want, i may split adding pcr_id.h first and push assessment patch for 2 SOC (APL and SKL) then add PCR library and finally using that common code
--
To view, visit
https://review.coreboot.org/18669
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78526a86b6d10f226570c08050327557e0bb2c78
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Barnali Sarkar
barnali.sarkar@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: dhaval v sharma
dhaval.v.sharma@intel.com
Gerrit-HasComments: Yes