[coreboot-gerrit] Change in coreboot[master]: device/Kconfig: select linear framebuffer for Tianocore

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39048 )

Change subject: device/Kconfig: select linear framebuffer for Tianocore
......................................................................

Patch Set 1: Code-Review+2

What Patrick meant on IRC: You can name a choice and then give
it a default later (if it has no default yet). This seems to
work, too:

diff --git a/payloads/external/tianocore/Kconfig b/payloads/external/tianocore/Kconfig
index 7717917f94..6d692ff8b0 100644
--- a/payloads/external/tianocore/Kconfig
+++ b/payloads/external/tianocore/Kconfig
@@ -102,4 +102,8 @@ config TIANOCORE_BOOTSPLASH_FILE
          If an absolute path is not given, the path will assumed to be
          relative to the coreboot root directory.

+choice FRAMEBUFFER_MODE
+       default GENERIC_LINEAR_FRAMEBUFFER if HAVE_LINEAR_FRAMEBUFFER
+endchoice
+
 endif
diff --git a/src/device/Kconfig b/src/device/Kconfig
index 603c7eb8d1..89f1c67a71 100644
--- a/src/device/Kconfig
+++ b/src/device/Kconfig
@@ -409,11 +409,10 @@ config FRAMEBUFFER_VESA_MODE
        default 0x118 if FRAMEBUFFER_VESA_MODE_USER
 endif # FRAMEBUFFER_SET_VESA_MODE

-choice
+choice FRAMEBUFFER_MODE
        prompt "Framebuffer mode"
        default VBE_LINEAR_FRAMEBUFFER if HAVE_VBE_LINEAR_FRAMEBUFFER && CHROMEOS
        default GENERIC_LINEAR_FRAMEBUFFER if HAVE_LINEAR_FRAMEBUFFER && CHROMEOS
-       default VGA_TEXT_FRAMEBUFFER

config VGA_TEXT_FRAMEBUFFER
        bool "Legacy VGA text mode"