Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47051 )
Change subject: mb/purism/librem_cnl: Adjust in preparation for new variants ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... PS1, Line 4: select SOC_INTEL_WHISKEYLAKE
The Kconfig.name thing is a bit of a hack to work around deficiencies in the Kconfig language. […]
I don't understand using HATCH as a model, when the boards listed in Kconfig.name there clearly select more than just the baseboard -- they select overrides, audio drivers, etc.
Having each board select the correct SoC and having everything else in Kconfig is the cleanest way to do it; otherwise, I'm defining two SoC-specific baseboards, each of which selects the LIBREM_CNL baseboard, all just to not have the SoC selected in Kconfig.name