Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39697 )
Change subject: nb/amd/agesa/family14: Improve HTC threshold handling
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39697/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39697/4//COMMIT_MSG@9
PS4, Line 9: According to BKDGs HTC temperature limit field indicates the threshold
It is actually 72 characters, AFAIUI
Okay, I was just following point 3 from here:
https://www.coreboot.org/Git#Commit_messages
Which states max 75.
https://doc.coreboot.org/tutorial/part2.html
also doesn't state the max liens in commit message. I guess we have found a hole in our docs. I may update the tutorial then.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39697
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife64c3aab76f8e125493ecc8183a6e87fb012e3b
Gerrit-Change-Number: 39697
Gerrit-PatchSet: 6
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Mar 2020 14:05:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment