Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37304 )
Change subject: vboot: Don't perform EC sync in recovery mode
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37304/1/src/security/vboot/ec_sync....
File src/security/vboot/ec_sync.c:
https://review.coreboot.org/c/coreboot/+/37304/1/src/security/vboot/ec_sync....
PS1, Line 61: vboot_save_nvdata_only(ctx);
Do we? NVDATA_CHANGED should never be set here when we're in recovery mode. […]
Yes, fair enough. Even though coreboot went and changed the nvdata backend value behind vboot's back, vboot *believes* it to be consistent with the vb2_context.nvdata value. So you are correct that nothing will be written here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37304
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb82396416d6b9af82fc75b3372f8339091469a4
Gerrit-Change-Number: 37304
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 28 Nov 2019 07:04:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Gerrit-MessageType: comment