Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35270 )
Change subject: soc/amd/common/lpc: Add decode disable function ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35270/1/src/soc/amd/common/block/lp... File src/soc/amd/common/block/lpc/lpc_util.c:
https://review.coreboot.org/c/coreboot/+/35270/1/src/soc/amd/common/block/lp... PS1, Line 173: void lpc_disable_decodes(void)
what does it do? Please add a comment.
Done
https://review.coreboot.org/c/coreboot/+/35270/2/src/soc/amd/common/block/lp... File src/soc/amd/common/block/lpc/lpc_util.c:
https://review.coreboot.org/c/coreboot/+/35270/2/src/soc/amd/common/block/lp... PS2, Line 179: +
Now it makes more sense, though also this should really be an OR instead of a PLUS. […]
It seems like some other reviews can tend toward + at times, but I'm OK either way. Certainly with values containing "COUNT", arithmetic look weird.