Attention is currently required from: Subrata Banik, Paul Menzel, Pratikkumar V Prajapati.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71117 )
Change subject: soc/intel/common: Add API to check Key Locker support ......................................................................
Patch Set 7:
(3 comments)
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/71117/comment/515e2ff6_469c0e55 PS7, Line 39: #define CPUID_STRUCT_EXTENDED_FEATURE_FLAGS 0x7 Use this macro?
https://review.coreboot.org/c/coreboot/+/71117/comment/d0739c3a_bc5d3f88 PS7, Line 200: cpuid_regs = cpuid_ext(CPUID_STRUCT_EXTENDED_FEATURE_FLAGS, 0); similar to here.
https://review.coreboot.org/c/coreboot/+/71117/comment/622e4808_62530c6f PS7, Line 542: 0x7 Could you update this to use the CPUID_STRUCT_EXTENDED_FEATURE_FLAGS definition?
Maybe do this in a follow-on patch, since the same code is used in several places above.
Maybe create an inline function to get the feature flags and use it across all of the functions?