Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43101 )
Change subject: mb/google/beltino: Put GPIOs in a C file
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43101/2/src/mainboard/google/beltin...
File src/mainboard/google/beltino/romstage.c:
https://review.coreboot.org/c/coreboot/+/43101/2/src/mainboard/google/beltin...
PS2, Line 14: extern const struct pch_lp_gpio_map mainboard_gpio_map[];
This declaration could instead go in lynxpoint/lp_gpio.h. Then it would […]
I've just seen that you deal with it in later commits.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43101
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I536225351a0353298381c16cff25f39098c19bba
Gerrit-Change-Number: 43101
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Jul 2020 13:36:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tristan Corrick
tristan@corrick.kiwi
Gerrit-MessageType: comment