[coreboot-gerrit] [L] Change in coreboot[main]: mb/hp: Add HP ProBook 640/650 G1

[Felix Singer (Code Review)]

Attention is currently required from: Iru Cai.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46130?usp=email )

Change subject: mb/hp: Add HP ProBook 640/650 G1
......................................................................

Patch Set 7:

(10 comments)

File src/mainboard/hp/probook_640_g1/Kconfig:

PS7: 
ADD SPDX license header

https://review.coreboot.org/c/coreboot/+/46130/comment/0649b20a_467ec798 :
PS7, Line 19: 	string
Avoid type redefinitions, remove.

https://review.coreboot.org/c/coreboot/+/46130/comment/61025e9e_a0a45c9f :
PS7, Line 23: 	string
Avoid type redefinitions, remove.

https://review.coreboot.org/c/coreboot/+/46130/comment/a3d481d1_1b8199d2 :
PS7, Line 27: 	string
Avoid type redefinitions, remove.

https://review.coreboot.org/c/coreboot/+/46130/comment/5bf505ef_29057c72 :
PS7, Line 31: 	int
Avoid type redefinitions, remove.

https://review.coreboot.org/c/coreboot/+/46130/comment/c4c901ce_f7b20584 :
PS7, Line 35: 	bool
Avoid type redefinitions, remove.

File src/mainboard/hp/probook_640_g1/Kconfig.name:

PS7: 
ADD SPDX license header

File src/mainboard/hp/probook_640_g1/Makefile.inc:

PS7: 
Makefiles use the ending .mk now. Please rename.

File src/mainboard/hp/probook_640_g1/devicetree.cb:

PS7: 
ADD SPDX license header

File src/mainboard/hp/probook_640_g1/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/46130/comment/39e2cbd1_821b99c4 :
PS7, Line 18: 	/* global NVS and variables. */
Seems superfluous, remove.