Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )
Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34532/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34532/2//COMMIT_MSG@11
PS2, Line 11: pass
Ack
Done
https://review.coreboot.org/c/coreboot/+/34532/2/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/sdram_configs.c:
https://review.coreboot.org/c/coreboot/+/34532/2/src/mainboard/google/kukui/...
PS2, Line 22: 0]
you are right, I have confirme this with hardware team, the RAM ID of K4UBE3D4AA-MGCL should be 8, n […]
Done
https://review.coreboot.org/c/coreboot/+/34532/5/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/sdram_params/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34532/5/src/mainboard/google/kukui/...
PS5, Line 2: sdram-params += sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB
Move this to the end for consistency with the source code.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34532
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27164f0909edb9d9398835e292fb845f0e342391
Gerrit-Change-Number: 34532
Gerrit-PatchSet: 5
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Sat, 10 Aug 2019 05:29:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: You-Cheng Syu
youcheng@google.com
Comment-In-Reply-To: huayang duan
huayangduan@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-MessageType: comment