Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41884 )
Change subject: drivers/intel/dptf: Add current participant Devices to DSDT ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41884/4/src/drivers/intel/dptf/dptf... File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/41884/4/src/drivers/intel/dptf/dptf... PS4, Line 60: CONFIG_DPTF_CPU_ADDR
Since we are using the System Thermal Agent device, can we use it's PCI BDF to construct this addres […]
I don't think that's true for all SoCs though, for APL/GLK the address was 0x0000_0001 (DPTF_CPU_ADDR)
https://review.coreboot.org/c/coreboot/+/41884/4/src/drivers/intel/dptf/dptf... PS4, Line 76: INT3404
for tigerlake these EISAID seems to be changed as per https://chromium-review.googlesource. […]
Is there a new DPTF spec that shows this information?
https://review.coreboot.org/c/coreboot/+/41884/4/src/drivers/intel/dptf/dptf... PS4, Line 101: acpigen_write_name_integer("TMPI", id);
What is this id? I am not able to find any reference to this Id in the DPTF document that I am looki […]
It was included in the previous implementation, and seemed to be only used in the vendor-specific functions (though because it's generated, TMPI can become obsolete, I just wasn't sure if it was strictly necessary to be exported or not).