Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42234 )
Change subject: libpayload: Fix potential compilation issues ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42234/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42234/2//COMMIT_MSG@9 PS2, Line 9: The include chain can define one of the macros (BIT, MIN, MAX are all They really shouldn't, though. I'm okay putting this in if it helps building some rogue payloads that just throw code together without really caring what's in there, but if this happens in libpayload code itself (or in depthcharge), please consider that a bug and fix it. We should not have duplicate (or worse, diverging) definitions of the same thing.