[coreboot-gerrit] Change in coreboot[master]: soc/intel: Factor out `select CPU_INTEL_COMMON`

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45042 )

Change subject: soc/intel: Factor out `select CPU_INTEL_COMMON`
......................................................................

Patch Set 1:

(1 comment)
> Patch Set 1: Code-Review-1
>
> I'm surprised that build bot didn't fail, since set_feature_ctrl_vmx from src/cpu/intel/common/common_init.c is getting used in src/soc/intel/skylake/cpu.c.
>
> Further, the CPPC code is getting used in SKL and after CB:45536 in the other socs, too

https://review.coreboot.org/c/coreboot/+/45042/1/src/soc/intel/skylake/cpu.c 
File src/soc/intel/skylake/cpu.c:

https://review.coreboot.org/c/coreboot/+/45042/1/src/soc/intel/skylake/cpu.c... 
PS1, Line 258: 	set_feature_ctrl_vmx();
> this is in src/cpu/intel/common/common_init.c ... Why does buildbot not fail? o. […]

Invalid. I missed the Kconfig change in soc/intel/common