Patch Set 1: Code-Review-1

I'm surprised that build bot didn't fail, since set_feature_ctrl_vmx from src/cpu/intel/common/common_init.c is getting used in src/soc/intel/skylake/cpu.c.

Further, the CPPC code is getting used in SKL and after CB:45536 in the other socs, too

View Change

1 comment:

To view, visit change 45042. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iedcd3073b8e0287908eab1d886d2d5efff09088b
Gerrit-Change-Number: 45042
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov@gmail.com>
Gerrit-Reviewer: David Guckian <david.guckian@intel.com>
Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 29 Sep 2020 16:43:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-MessageType: comment