Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34980 )
Change subject: southbridge/intel: Tidy up preprocessor and headers
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34980/6/src/southbridge/intel/lynxp...
File src/southbridge/intel/lynxpoint/lp_gpio.c:
https://review.coreboot.org/c/coreboot/+/34980/6/src/southbridge/intel/lynxp...
PS6, Line 27: #ifdef __SIMPLE_DEVICE__
: return pci_read_config16(PCH_LPC_DEV, GPIO_BASE) & 0xfffc;
: #else
: return pci_read_config16(pcidev_on_root(0x1f, 0),
: GPIO_BASE) & 0xfffc;
: #endif
This should probably be changed to pci_s_read_config16?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34980
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52a7b39566acd64ac21a345046675e05649a40f5
Gerrit-Change-Number: 34980
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 21 Aug 2019 06:10:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment