Attention is currently required from: Maulik V Vaghela, Jeremy Soller, Michał Kopeć, Tim Wawrzynczak, Paul Menzel, Ronak Kanabar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64074 )
Change subject: soc/intel/alderlake/hsphy: Add support for HSPHY firmware loading ......................................................................
Patch Set 4: Verified-1
(11 comments)
File src/soc/intel/alderlake/hsphy.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150249): https://review.coreboot.org/c/coreboot/+/64074/comment/69dafca1_cb794f5e PS4, Line 28: #define HSPHY_PAYLOAD_SIZE 32*KiB Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150249): https://review.coreboot.org/c/coreboot/+/64074/comment/279498da_ce94b4e9 PS4, Line 40: #define HSPHY_MEM_VERIFIER_ERROR_STATUS (HSPHY_VERIFIER_BASE + 0x30) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150249): https://review.coreboot.org/c/coreboot/+/64074/comment/6cfb9efe_986531a3 PS4, Line 67: }__packed; space required after that close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150249): https://review.coreboot.org/c/coreboot/+/64074/comment/b36f5505_cf92a65f PS4, Line 159: printk (BIOS_ERR, "Hash alg %d not supported, try SHA384\n", hash_alg); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150249): https://review.coreboot.org/c/coreboot/+/64074/comment/a71774e6_d6e90ac8 PS4, Line 186: i += sizeof (*push_model); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150249): https://review.coreboot.org/c/coreboot/+/64074/comment/f72ccd2b_e203df06 PS4, Line 188: if ((push_model->address == 0) && (push_model->count == 0)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150249): https://review.coreboot.org/c/coreboot/+/64074/comment/e5885163_58febade PS4, Line 194: i += sizeof (uint32_t); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150249): https://review.coreboot.org/c/coreboot/+/64074/comment/31f5183b_eabb2dff PS4, Line 275: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150249): https://review.coreboot.org/c/coreboot/+/64074/comment/4922592b_2bf11749 PS4, Line 312: hsphy_ver = REGBAR32(CPU_PID_PCIE_PHYx16_0, HSPHY_FW_VERSION);; Statements terminations use 1 semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150249): https://review.coreboot.org/c/coreboot/+/64074/comment/329bd48d_36ac0dc2 PS4, Line 317: hsphy_ver = REGBAR32(CPU_PID_PCIE_PHYx16_1, HSPHY_FW_VERSION);; Statements terminations use 1 semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150249): https://review.coreboot.org/c/coreboot/+/64074/comment/34cef7f3_117f7951 PS4, Line 344: } adding a line without newline at end of file