Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45878 )
Change subject: tigerlake mainboards: switch to devtree aliases for PMC MUX connectors ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45878/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45878/4/src/mainboard/google/voltee... PS4, Line 29: This is an ugly hack
I do intend to come back and clean it up 🐨 How about `pcidev_path_on_root(PCH_DEVFN_PMC)` ?
Done
https://review.coreboot.org/c/coreboot/+/45878/4/src/mainboard/google/voltee... PS4, Line 32: dev_find_matching_device_on_bus(__pci_0_1f_2->link_list,
Yes, it certainly is, good catch, needs to traverse its grandchildren.
Done
https://review.coreboot.org/c/coreboot/+/45878/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45878/6/src/mainboard/google/voltee... PS6, Line 23: dev->path.generic.id == 1;
You can also add an additional check to ensure that dev->chip_ops == drivers_intel_pmc_mux_conn_ops […]
Sure could, but those checks are so, how shall we say, inelegant 😄? There's got to be a better way to establish device "identity" than a `void *`... or maybe a new bus type "virtual" or similar