[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8183: Add DSI driver

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31591 )

Change subject: soc/mediatek/mt8183: Add DSI driver
......................................................................

Patch Set 47: Code-Review+2

(3 comments)

https://review.coreboot.org/c/coreboot/+/31591/47/src/soc/mediatek/common/in... 
File src/soc/mediatek/common/include/soc/dsi_common.h:

https://review.coreboot.org/c/coreboot/+/31591/47/src/soc/mediatek/common/in... 
PS47, Line 69: 	u32 dsi_lfr_con;
nit: add comment which registers are only available since 8183?

https://review.coreboot.org/c/coreboot/+/31591/47/src/soc/mediatek/mt8183/ds... 
File src/soc/mediatek/mt8183/dsi.c:

https://review.coreboot.org/c/coreboot/+/31591/47/src/soc/mediatek/mt8183/ds... 
PS47, Line 45: 		// MIN = 125
C89 comments

https://review.coreboot.org/c/coreboot/+/31591/47/src/soc/mediatek/mt8183/ds... 
PS47, Line 59: 26
Is this related to CLK26M_HZ? If so, please use that constant for clarity.