Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46120 )
Change subject: mb/google/poppy/variant/atlas: Reset bluetooth on boot
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46120/2/src/mainboard/google/poppy/...
File src/mainboard/google/poppy/variants/atlas/gpio.c:
https://review.coreboot.org/c/coreboot/+/46120/2/src/mainboard/google/poppy/...
PS2, Line 335: early_gpio_table
I'm not familiar with atlas, but if the timing works out, you could add something to romstage or eve […]
+1. You can assert it in romstage so that the regular GPIO table deasserts it. As Tim mentioned, you will have to check if there are any timing requirements about how long the signal needs to be asserted.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46120
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I361caa49e82aa086c3c35962164fb078fa30139e
Gerrit-Change-Number: 46120
Gerrit-PatchSet: 2
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 14 Oct 2020 17:13:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment