[coreboot-gerrit] Change in ...coreboot[master]: grunt: Change Bayhub eMMC clock to 208MHz

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33430 )

Change subject: grunt: Change Bayhub eMMC clock to 208MHz
......................................................................

Patch Set 1: Code-Review-1

(1 comment)

I'll rework the patch

https://review.coreboot.org/#/c/33430/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33430/1//COMMIT_MSG@17 
PS1, Line 17:
> So what happens if tuning fails. […]

You bring up a good point. Currently the way the code is written if tuning fails, the broken screen is shown. We should change depthcharge to fall back to a slower speed. I think this also convinces me that we shouldn't override the SDHC clock setting in coreboot, but instead tell the BH part to respect it. This way depthcharge can change the clock sleep without vendor specific code.