Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46723 )
Change subject: libpayload/keyboard: Use `bool` as return type
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46723/1/payloads/libpayload/drivers...
File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/46723/1/payloads/libpayload/drivers...
PS1, Line 311: (int (*)(void))
heh, didn't know one can cast function pointers
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46723
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I876bb5076c4921f36e3438f359be8ac4c09248cc
Gerrit-Change-Number: 46723
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 24 Oct 2020 19:20:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment