Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31892 )
Change subject: src: Add missing 'include <types.h>' ......................................................................
Patch Set 9:
(7 comments)
https://review.coreboot.org/#/c/31892/9/src/northbridge/intel/i945/early_ini... File src/northbridge/intel/i945/early_init.c:
https://review.coreboot.org/#/c/31892/9/src/northbridge/intel/i945/early_ini... PS9, Line 27: #include "i945.h" delete double include
https://review.coreboot.org/#/c/31892/9/src/soc/qualcomm/ipq40xx/include/soc... File src/soc/qualcomm/ipq40xx/include/soc/clock.h:
https://review.coreboot.org/#/c/31892/9/src/soc/qualcomm/ipq40xx/include/soc... PS9, Line 35: #include <types.h> Why do you need it here? Can't see anything that needs types.h
https://review.coreboot.org/#/c/31892/9/src/soc/samsung/exynos5250/gpio.c File src/soc/samsung/exynos5250/gpio.c:
https://review.coreboot.org/#/c/31892/9/src/soc/samsung/exynos5250/gpio.c@22 PS9, Line 22: #include <types.h> Why do you need it here? Can't see anything that needs types.h
https://review.coreboot.org/#/c/31892/9/src/soc/samsung/exynos5420/gpio.c File src/soc/samsung/exynos5420/gpio.c:
https://review.coreboot.org/#/c/31892/9/src/soc/samsung/exynos5420/gpio.c@22 PS9, Line 22: #include <types.h> Why do you need it here? Can't see anything that needs types.h
https://review.coreboot.org/#/c/31892/9/src/southbridge/amd/pi/hudson/hudson... File src/southbridge/amd/pi/hudson/hudson.c:
https://review.coreboot.org/#/c/31892/9/src/southbridge/amd/pi/hudson/hudson... PS9, Line 25: #include <types.h> Add a new line here
https://review.coreboot.org/#/c/31892/9/src/vendorcode/intel/fsp/fsp2_0/cann... File src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspmUpd.h:
https://review.coreboot.org/#/c/31892/9/src/vendorcode/intel/fsp/fsp2_0/cann... PS9, Line 36: #include <types.h> Add in alphabetical order. Thoughm why do we need it here? UEFI code has its own types.
https://review.coreboot.org/#/c/31892/9/src/vendorcode/intel/fsp/fsp2_0/come... File src/vendorcode/intel/fsp/fsp2_0/cometlake/FspmUpd.h:
https://review.coreboot.org/#/c/31892/9/src/vendorcode/intel/fsp/fsp2_0/come... PS9, Line 36: #include <types.h> same here