build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42573 )
Change subject: mainboard/tigerlake: Implement RTD3 for SSD ......................................................................
Patch Set 2:
(9 comments)
https://review.coreboot.org/c/coreboot/+/42573/2/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/pcie.asl:
https://review.coreboot.org/c/coreboot/+/42573/2/src/soc/intel/tigerlake/acp... PS2, Line 363: // WA for the follwing sighting (L23R2DT is no longer cleared by HW if set when LTMSS is not in L23_Rdy) 'follwing' may be misspelled - perhaps 'following'?
https://review.coreboot.org/c/coreboot/+/42573/2/src/soc/intel/tigerlake/acp... PS2, Line 606: // WA for the follwing sighting (L23R2DT is no longer cleared by HW if set when LTMSS is not in L23_Rdy) 'follwing' may be misspelled - perhaps 'following'?
https://review.coreboot.org/c/coreboot/+/42573/2/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/pmc.asl:
https://review.coreboot.org/c/coreboot/+/42573/2/src/soc/intel/tigerlake/acp... PS2, Line 314: #define V_PMC_PWRM_IPC_CMD_COMMAND_SLP_CTRL 0xA1 ///< IPC commmand to control S0ix policies 'commmand' may be misspelled - perhaps 'command'?
https://review.coreboot.org/c/coreboot/+/42573/2/src/soc/intel/tigerlake/acp... PS2, Line 315: #define V_PMC_PWRM_IPC_CMD_COMMAND_SNDW_RCOMP 0xA2 ///< IPC commmand to control platform Soundwire buffer RCOMP 'commmand' may be misspelled - perhaps 'command'?
https://review.coreboot.org/c/coreboot/+/42573/2/src/soc/intel/tigerlake/acp... PS2, Line 316: #define V_PMC_PWRM_IPC_CMD_COMMAND_FIVR 0xA3 ///< IPC commmand to control FIVR Configuration 'commmand' may be misspelled - perhaps 'command'?
https://review.coreboot.org/c/coreboot/+/42573/2/src/soc/intel/tigerlake/acp... PS2, Line 324: #define V_PMC_PWRM_IPC_CMD_COMMAND_NPK_STATE 0xA4 ///< IPC commmand to control NPK Power State 'commmand' may be misspelled - perhaps 'command'?
https://review.coreboot.org/c/coreboot/+/42573/2/src/soc/intel/tigerlake/acp... PS2, Line 729: #define B_PMC_PWRM_ACPI_CNT_ACPI_EN BIT7 ///< ACPI eanble 'eanble' may be misspelled - perhaps 'enable'?
https://review.coreboot.org/c/coreboot/+/42573/2/src/soc/intel/tigerlake/acp... PS2, Line 906: // 3 Timeout Occured 'Occured' may be misspelled - perhaps 'Occurred'?
https://review.coreboot.org/c/coreboot/+/42573/2/src/soc/intel/tigerlake/acp... PS2, Line 963: Store(3, Index(RPKG, 0)) // Store Errorcode of Timeout Occured to Status 'Occured' may be misspelled - perhaps 'Occurred'?