Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39352 )
Change subject: lib/spd_bin: Extend LPDDR4 spd information ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39352/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39352/2//COMMIT_MSG@7 PS2, Line 7: spd SPD
https://review.coreboot.org/c/coreboot/+/39352/2//COMMIT_MSG@9 PS2, Line 9: spd SPD
https://review.coreboot.org/c/coreboot/+/39352/2/src/include/spd_bin.h File src/include/spd_bin.h:
https://review.coreboot.org/c/coreboot/+/39352/2/src/include/spd_bin.h@a44 PS2, Line 44: #define LPDDR4_SPD_PART_LEN 20 Why remove this?
https://review.coreboot.org/c/coreboot/+/39352/2/src/lib/spd_bin.c File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/39352/2/src/lib/spd_bin.c@81 PS2, Line 81: 96, 12, 24, 72 }; More stuff fits on the line above in 96 characters.
https://review.coreboot.org/c/coreboot/+/39352/2/src/lib/spd_bin.c@180 PS2, Line 180: printk(BIOS_INFO, "SPD: module part number is %s\n", spd_name); Should be a separate commit.