Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44060 )
Change subject: soc/intel/{icl.tgl,jsl}: Remove SMRAM register programming
......................................................................
Patch Set 1:
Patch Set 1:
So if I understand correctly, right now SMRAM on these platforms remains unlocked after coreboot loads the payload?
This are compatible SMRAM region locking not the actual DRAM based SMRAM locking stuff. This register controls below 1 MB VGA region (0xA_0000 till 0xB_FFFF)
Here is the register range that this register protects:
C_BASE_SEG: This field indicates the location of SMM space. Only SMM space between A_0000h and
B_FFFFh is supported, so this field is hardwired to 010b
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44060
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f581b90ea99012980f439a7914e8d901585b004
Gerrit-Change-Number: 44060
Gerrit-PatchSet: 1
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 31 Jul 2020 03:26:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment