Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36300 )
Change subject: vboot: use vboot persistent context
......................................................................
Patch Set 15:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36300/2/src/security/vboot/common.c
File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36300/2/src/security/vboot/common.c...
PS2, Line 146: VB2_KERNEL_WORKBUF_RECOMMENDED_SIZE
Right now it's guaranteed to be 32 byte aligned (via imd_create_tiered_empty() setting up alignment […]
Ack
https://review.coreboot.org/c/coreboot/+/36300/7/src/security/vboot/common.c
File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36300/7/src/security/vboot/common.c...
PS7, Line 49: memset(wd, 0, VB2_FIRMWARE_WORKBUF_RECOMMENDED_SIZE);
coreboot takes care of zeroing the vboot_working_data struct. […]
Ack
https://review.coreboot.org/c/coreboot/+/36300/6/src/security/vboot/misc.h
File src/security/vboot/misc.h:
https://review.coreboot.org/c/coreboot/+/36300/6/src/security/vboot/misc.h@3...
PS6, Line 35: vboot_init_context
can you make a follow-up CL to fix the comment?
See CB:36862
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36300
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I051be1e47bf79b15a1689d49a5d4c031e9363dfa
Gerrit-Change-Number: 36300
Gerrit-PatchSet: 15
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 15 Nov 2019 10:37:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment