Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39816 )
Change subject: src: Include <smbios.h> when appropriate
......................................................................
Patch Set 5:
(1 comment)
All the removals look good.
https://review.coreboot.org/c/coreboot/+/39816/4/src/include/device/device.h
File src/include/device/device.h:
PS4:
This change is questionable, because the declaration of `struct smbios_type11`
here shows that it was not included intentionally.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39816
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12345a5b6c9ce94ca9f8b555154b2278a8ff97bf
Gerrit-Change-Number: 39816
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 05 Apr 2020 17:41:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment