Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42797 )
Change subject: sb/intel/ibexpeak/smihandler: Comment out unused variable assignment ......................................................................
sb/intel/ibexpeak/smihandler: Comment out unused variable assignment
Fix the scan-build warning below:
CC smm/southbridge/intel/ibexpeak/smihandler.o src/southbridge/intel/ibexpeak/smihandler.c:135:4: warning: Value stored to 'data' is never read data &= mask; ^ ~~~~ 1 warning generated.
Change-Id: I62060aacfec72a7066ee8c6464231c2ad5203a2a Found-by: scan-build (clang-tools-9 1:9.0.1-12) Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/southbridge/intel/ibexpeak/smihandler.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/42797/1
diff --git a/src/southbridge/intel/ibexpeak/smihandler.c b/src/southbridge/intel/ibexpeak/smihandler.c index a881f33..861d18e 100644 --- a/src/southbridge/intel/ibexpeak/smihandler.c +++ b/src/southbridge/intel/ibexpeak/smihandler.c @@ -132,7 +132,7 @@ if (!(trap_cycle & (1 << 24))) { // It's a write printk(BIOS_DEBUG, "SMI1 command\n"); data = RCBA32(0x1e18); - data &= mask; + // data &= mask; // if (smi1) // southbridge_smi_command(data); // return;