Attention is currently required from: Nicholas Sudsgaard, Paul Menzel, Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81205?usp=email )
Change subject: ec/hp/kbc1126/acpi: Drop unnecessary method arguments
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
Patchset:
PS3:
I think it would be fair to assume anyone writing ASL would know about the defaults up to `NotSerial […]
I wouldn't say "know" but I expect most people would guess right (if there is
an serialization option, why would it be on by default?). :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81205?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic24e004500a7fa2a5a5b38a3f6f0e13e4ce7dfac
Gerrit-Change-Number: 81205
Gerrit-PatchSet: 6
Gerrit-Owner: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Comment-Date: Sat, 16 Mar 2024 13:56:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
inforichland@gmail.com
Comment-In-Reply-To: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-MessageType: comment