Attention is currently required from: Marshall Dawson, Kyösti Mälkki, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63387 )
Change subject: drivers/usb/pci_ehci.c: Move away from __SIMPLE_DEVICE__ ......................................................................
Patch Set 4:
(5 comments)
File src/drivers/usb/pci_ehci.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145492): https://review.coreboot.org/c/coreboot/+/63387/comment/02f997ab_64ff2a93 PS4, Line 91: const struct device *dbg_dev = pci_ehci_dbg_dev(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145492): https://review.coreboot.org/c/coreboot/+/63387/comment/b872585b_6bd02b26 PS4, Line 91: const struct device *dbg_dev = pci_ehci_dbg_dev(); please, no spaces at the start of a line
File src/southbridge/intel/common/usb_debug.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145492): https://review.coreboot.org/c/coreboot/+/63387/comment/638225f6_cb61cbd9 PS4, Line 13: const struct device *dev; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145492): https://review.coreboot.org/c/coreboot/+/63387/comment/4b6819a3_4022ff0d PS4, Line 13: const struct device *dev; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145492): https://review.coreboot.org/c/coreboot/+/63387/comment/a8d5bfa4_901ea7ac PS4, Line 27: if (class != PCI_EHCI_CLASSCODE) { braces {} are not necessary for single statement blocks