Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48270 )
Change subject: soc/amd/picassso/acpi: increase MMIO region size of GPIO controller
......................................................................
Patch Set 2:
Patch Set 2:
I'm not seeing it yet. Can you let me know (offline's OK) what doc you're looking at?
see the chapter FCH/registers/GPIO pin control registers/GPIO registers of #55570. There are 4 banks of GPIOs (0-3) and they start 0x100 bytes apart from each other, so 0x400 bytes in total
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48270
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I453f1c531d612a0e82ee0d91762fec6cdb2b8556
Gerrit-Change-Number: 48270
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 04 Dec 2020 13:38:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment