Attention is currently required from: Philipp Hug, Patrick Rudolph, Christian Walter, ron minnich.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64735 )
Change subject: cbfs: Rename TYPE_FIT to TYPE_FIT_PAYLOAD
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64735/comment/e487c917_4e25f565
PS1, Line 13: fit_payload`).
Are you aware of any script that needs to be changed?
No, that's why I added Patrick to the CC... he added that functionality and I'm not aware of anyone else using it. There are no instances of this in the coreboot tree but there may be in other organizations' external build scripts.
File util/nvramtool/cbfs.h:
https://review.coreboot.org/c/coreboot/+/64735/comment/fc51b278_98dcc62e
PS1, Line 29: #define CBFS_TYPE_FIT_PAYLOAD 0x21
Can we align these with tabs?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64735
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I826cefce54ade06c6612c8a7bb53e02092e7b11a
Gerrit-Change-Number: 64735
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Wed, 01 Jun 2022 00:30:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment