Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32939 )
Change subject: nb/intel/x4x: Remove variable set but not used
......................................................................
Patch Set 1:
Patch Set 1: Code-Review-1
The resulting assembly is not the same, you'd want to test it on hardware if it is functionally equivalent. That the variable is not used is normal, since sending jedec command is simply done by reading a certain address on the DIMM. You obviously don't care about the result since the ram is not yet initialized.
See new commentary on CB:32948.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I142ae6f7806b3f57b98a158e8f26592aed8fa452
Gerrit-Change-Number: 32939
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 23 May 2019 16:15:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment