Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79219?usp=email )
Change subject: [UNTESTED] acpi/acpi: add & use ACPI_DBG2_PORT_SERIAL_16550_GENERIC ......................................................................
[UNTESTED] acpi/acpi: add & use ACPI_DBG2_PORT_SERIAL_16550_GENERIC
The Microsoft Debug Port Table 2 (DBG2) specification says that the serial port subtype 0x00 (in coreboot ACPI_DBG2_PORT_SERIAL_16550) should only be used for I/O-mapped 16550 compatible UARTs. The subtype 0x12 is a superset of that, and supports specifying MMIO vs IO and the register access size via the generic address structure.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I816bb22e6f76e661c8b8e39a2a4cb83b0085acb5 --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/79219/1
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 17cd24c..6070685 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -834,7 +834,7 @@ int subtype; /* 16550-compatible with parameters defined in Generic Address Structure */ if (CONFIG(DRIVERS_UART_8250IO) || CONFIG(DRIVERS_UART_8250MEM)) - subtype = ACPI_DBG2_PORT_SERIAL_16550; + subtype = ACPI_DBG2_PORT_SERIAL_16550_GENERIC; else if (CONFIG(DRIVERS_UART_PL011)) subtype = ACPI_DBG2_PORT_SERIAL_ARM_PL011; else diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 9a9a66d..55804fc 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -872,6 +872,7 @@ #define ACPI_DBG2_PORT_SERIAL_ARM_SBSA 0x000e #define ACPI_DBG2_PORT_SERIAL_ARM_DDC 0x000f #define ACPI_DBG2_PORT_SERIAL_BCM2835 0x0010 +#define ACPI_DBG2_PORT_SERIAL_16550_GENERIC 0x0012 #define ACPI_DBG2_PORT_IEEE1394 0x8001 #define ACPI_DBG2_PORT_IEEE1394_STANDARD 0x0000 #define ACPI_DBG2_PORT_USB 0x8002