[coreboot-gerrit] [XL] Change in coreboot[main]: soc/mediatek/mt8196: Add thermal driver

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.

Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86017?usp=email )

Change subject: soc/mediatek/mt8196: Add thermal driver
......................................................................

Patch Set 4:

(3 comments)

File src/soc/mediatek/mt8196/mt_thermal.c:

https://review.coreboot.org/c/coreboot/+/86017/comment/37fd7ab2_0bb1f209?usp... :
PS2, Line 7: #include <stddef.h>
           : #include <stdlib.h>
           : #include <stdio.h>
           : #include <string.h>
> what are those for ? […]

Done

https://review.coreboot.org/c/coreboot/+/86017/comment/c61f95cc_09730656?usp... :
PS2, Line 318: 0x%x,
> %#x

Done

File src/soc/mediatek/mt8196/thermal.c:

https://review.coreboot.org/c/coreboot/+/86017/comment/c109704b_aa916938?usp... :
PS4, Line 324: 	op_cali[LVTS_AP_CONTROLLER0] = temp[5] & GENMASK(29, 24) >> 24;
> `Possible precedence defect with mask then right shift - may need parentheses`

Please fix.