Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35293 )
Change subject: Add ThinkPad R60 iGPU support.
......................................................................
Patch Set 20: Code-Review+1
(1 comment)
Otherwise looks good to me.
https://review.coreboot.org/c/coreboot/+/35293/20/src/mainboard/lenovo/r60/g...
File src/mainboard/lenovo/r60/gpio.c:
https://review.coreboot.org/c/coreboot/+/35293/20/src/mainboard/lenovo/r60/g...
PS20, Line 78: const struct pch_gpio_set1 pch_gpio_set1_blink = {
It won't hurt anyone to add static here as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35293
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14ea3b91b5108652ce3f951bacea1c1f022da2b1
Gerrit-Change-Number: 35293
Gerrit-PatchSet: 20
Gerrit-Owner: Name of user not set #1002571
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Name of user not set #1002571
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 12 Sep 2019 10:51:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment