Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80735?usp=email )
Change subject: lib: Explicitly declare heap as NOLOAD
......................................................................
Patch Set 5:
(1 comment)
File src/lib/program.ld:
https://review.coreboot.org/c/coreboot/+/80735/comment/3fc15f56_7ba72d2c :
PS4, Line 120: .bss . : {
I mean, Max is right: the BSS should also have the NOLOAD flag. I assume that both LLVM and BFD linkers have the section name ".bss" hardcoded as something that always gets that by default, whereas with ".heap" it's a more complicated heuristic where the behavior between the two differs.
Do you mean that zeroing out the .bss region at load time, does not count as loading? I'm confused about the semantics here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80735?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3ca7221d10f144f608823e0b9624533780fbf335
Gerrit-Change-Number: 80735
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 27 Feb 2024 06:58:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment