Marx Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38741 )
Change subject: soc/intel/cannonlake: Add tdc config for CML ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38741/13/src/soc/intel/cannonlake/v... File src/soc/intel/cannonlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/38741/13/src/soc/intel/cannonlake/v... PS13, Line 425:
This could be const too.
Done
https://review.coreboot.org/c/coreboot/+/38741/14/src/soc/intel/cannonlake/v... File src/soc/intel/cannonlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/38741/14/src/soc/intel/cannonlake/v... PS14, Line 506: printk(BIOS_ERR, "ERROR: Unknown MCH (0x%x) in VR-config, so apply defaults\n", mch_id);
line over 96 characters
Done