[coreboot-gerrit] Change in ...coreboot[master]: security/vboot: Add measured boot mode

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29547 )

Change subject: security/vboot: Add measured boot mode
......................................................................

Patch Set 43:

(2 comments)

https://review.coreboot.org/#/c/29547/43/src/security/vboot/vboot_crtm.c 
File src/security/vboot/vboot_crtm.c:

https://review.coreboot.org/#/c/29547/43/src/security/vboot/vboot_crtm.c@56 
PS43, Line 56:
> There are different arguments for tpm_measure_region() in both cases. […]

it's  struct region_device * in both cases

https://review.coreboot.org/#/c/29547/43/src/security/vboot/vboot_crtm.c@80 
PS43, Line 80: 	if (IS_ENABLED(CONFIG_VBOOT_SEPARATE_VERSTAGE)) {
> Why? The upper code deals with romstage while this one deals with verstage. […]

probably doesn't matter as the linker will drop code anyway