build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31531 )
Change subject: intelvbttool: Added support for reading vbt from sysfs ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/31531/1/util/intelvbttool/intelvbttool.c File util/intelvbttool/intelvbttool.c:
https://review.coreboot.org/#/c/31531/1/util/intelvbttool/intelvbttool.c@409 PS1, Line 409: if ( read_size == 0 ) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/31531/1/util/intelvbttool/intelvbttool.c@409 PS1, Line 409: if ( read_size == 0 ) space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31531/1/util/intelvbttool/intelvbttool.c@420 PS1, Line 420: while((cb = fread(fo->data + bytes_read, 1, read_size, fd)) > 0) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/31531/1/util/intelvbttool/intelvbttool.c@422 PS1, Line 422: struct fileobject* newfo = remalloc_fo(fo, fo->size + read_size); line over 80 characters
https://review.coreboot.org/#/c/31531/1/util/intelvbttool/intelvbttool.c@422 PS1, Line 422: struct fileobject* newfo = remalloc_fo(fo, fo->size + read_size); "foo* bar" should be "foo *bar"